Skip to content

chore: Translation Module Convenience #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

chore: Translation Module Convenience #646

wants to merge 42 commits into from
+184 −30

Conversation

@n-o-u-r-h-a-n
Copy link
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Nov 6, 2025 •
edited
Loading

Context

AI/ai-sdk-java-backlog#325.

Adding convenience methods for both input and output translation configs respectively.

Feature scope:

  • Added a builder class and convenience method in SAPDocumentTranslationInput class.
  • Added a builder class and convenience method in SAPDocumentTranslationOutput class.
  • Updated Translation method in OrchestrationService class accordingly.
  • Updated release notes.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

n-o-u-r-h-a-n and others added 26 commits November 6, 2025 15:03
@n-o-u-r-h-a-n
Updates
ca75f86
@n-o-u-r-h-a-n
Merge branch 'main' into translation-module-convenience
092c1fc
@n-o-u-r-h-a-n
Merge branch 'main' into translation-module-convenience
082ec9a
@n-o-u-r-h-a-n
formatting
861df11
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/translation-module-convenience' …
ef484ea 
…into translation-module-convenience
@bot-sdk-js
Formatting
63dd65f
@n-o-u-r-h-a-n
check
519cd75
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/translation-module-convenience' …
1d13880 
…into translation-module-convenience
@bot-sdk-js
Formatting
108730a
@n-o-u-r-h-a-n
more formatting
4b97583
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/translation-module-convenience' …
ae4f5e3 
…into translation-module-convenience
@bot-sdk-js
Formatting
7c2a641
@n-o-u-r-h-a-n
run tests
35e5035
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/translation-module-convenience' …
e937917 
…into translation-module-convenience
@bot-sdk-js
Formatting
5a9740a
@n-o-u-r-h-a-n
run tests
e5974e6
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/translation-module-convenience' …
64e01b7 
…into translation-module-convenience
@n-o-u-r-h-a-n
fix error1
c85c2ff
@bot-sdk-js
Formatting
a97bfec
@n-o-u-r-h-a-n
Revert generated models to match origin/main
7e64b07 
# Conflicts:
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/SAPDocumentTranslationOutput.java
@n-o-u-r-h-a-n
making 2 model classes just like main
964271f
@n-o-u-r-h-a-n
chore: retrigger CI
130f454
@n-o-u-r-h-a-n
checking
0e5a395
@n-o-u-r-h-a-n
chore: retrigger CI
60b101b
@n-o-u-r-h-a-n
matching the CI
b9baee5
@bot-sdk-js
Formatting
7f40361
@n-o-u-r-h-a-n n-o-u-r-h-a-n removed the request for review from CharlesDuboisSAP November 7, 2025 13:24
@n-o-u-r-h-a-n n-o-u-r-h-a-n added the please-review Request to review a pull-request label Nov 7, 2025
Jonas-Isr
Jonas-Isr reviewed Nov 10, 2025
View reviewed changes
@newtork newtork removed the please-review Request to review a pull-request label Nov 17, 2025
@n-o-u-r-h-a-n n-o-u-r-h-a-n added the please-review Request to review a pull-request label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP left review comments

@Jonas-Isr Jonas-Isr Jonas-Isr left review comments

@newtork newtork Awaiting requested review from newtork

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

please-review Request to review a pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@n-o-u-r-h-a-n @newtork @CharlesDuboisSAP @Jonas-Isr @bot-sdk-js @rpanackal